This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Added supported for gamma function. #9
Open
newptcai
wants to merge
4
commits into
JuliaIntervals:master
Choose a base branch
from
newptcai:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for the delay in seeing this and thanks for the contribution! Do you have any idea what the problem is? |
It looks like the failures are on Julia 0.6 (!) which we no longer should support. Would you mind adding a Project.toml and testing on Julia 1.4? |
Sorry I am getting a bit busy. Maybe this can wait a while? |
Yes of course, no rush - thanks! |
The problem with erfinv is that in
The call to roots get stuck and never returns. That's why I commented out tests for erfinv and erfinvc. |
What's the status here? |
Cross-reference to the original issue in IntervalArithmetic.jl: |
@newptcai @dpsanders Any updates? Would be a useful thing to have :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note that there is some problem with
erfinv
anderfcinv
. Some old test cases can not finish in reasonable time. I have commented them out.