test: Fix: adjust "structs not in Base" test
#842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not test the exact return type of `Fix{1}(MyStruct, 1)`. That does
not seem necessary, given that the intention behind the test is
merely ensuring that `Fix` works correctly for a newly-defined
`MyStruct`.
* Test that `Fix{1}(MyStruct, 1)()` calls `MyStruct(1)`.
The motivation is making PkgEval pass for PR JuliaLang/julia#59623.
nsajko
changed the title
Fix: adjust "structs not in Base" testFix: adjust "structs not in Base" test
Member
martinholters
left a comment
martinholters
left a comment
There was a problem hiding this comment.
I'm not convinced JuliaLang/julia#59623 is the way to go, but this test shouldn't stand in the way; ok with me to weaken it.
Member
|
You can also bump the version, so that we can do a release immediately after merging. |
Co-authored-by: Martin Holters <[email protected]>
nsajko
commented
Sep 24, 2025
nsajko
commented
Sep 24, 2025
martinholters
approved these changes
Sep 25, 2025
Member
Author
|
merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not test the exact return type of
Fix{1}(MyStruct, 1). That does not seem necessary, given that the intention behind the test is merely ensuring thatFixworks correctly for a newly-definedMyStruct.Test that
Fix{1}(MyStruct, 1)()callsMyStruct(1).The motivation is making PkgEval pass for PR JuliaLang/julia#59623.