Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unitary matrices in svd/eigen of Diagonal be unitless #1155

Merged
merged 7 commits into from
Feb 19, 2025

Merge branch 'master' into dk/diag_svd_eigen

ade63a0
Select commit
Loading
Failed to load commit list.
Merged

Make unitary matrices in svd/eigen of Diagonal be unitless #1155

Merge branch 'master' into dk/diag_svd_eigen
ade63a0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 18, 2025 in 1s

91.88% (-0.01%) compared to b464203, passed because coverage increased by 0% when compared to adjusted base (91.88%)

View this Pull Request on Codecov

91.88% (-0.01%) compared to b464203, passed because coverage increased by 0% when compared to adjusted base (91.88%)

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (b464203) to head (ade63a0).

Files with missing lines Patch % Lines
src/diagonal.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files          34       34              
  Lines       15374    15376       +2     
==========================================
+ Hits        14127    14128       +1     
- Misses       1247     1248       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.