Revert "Use BLAS.trsm! instead of LAPACK.trtrs! in left-triangular solves"

[vtjnash]

Reverts #1194 since it introduced a bug into BaseBenchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (b7bffc1) to head (15bb46a).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
+ Coverage   91.95%   91.98%   +0.02%     
==========================================
  Files          34       34              
  Lines       15465    15454      -11     
==========================================
- Hits        14221    14215       -6     
+ Misses       1244     1239       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ViralBShah]

Do we have an issue that links to the failure? I thought we had one somewhere - but can't find it. We need to open an issue with the failing CI test case.

cc @dkarrasch

[KristofferC]

Would be good to understand a bit better what the issue here is. Is the problem in the BaseBenchmark code for example?

[vtjnash]

The logs show this code erroring, which is all that I know:

      From worker 3:    2025-03-07T23:18:44.246 | starting benchscript.jl (STDOUT/STDERR will be redirected to the result folder)                                      [162/1889]
      From worker 3:    ERROR: LoadError: SingularException: matrix is singular; factorization failed. Zero pivot found at index 769                                             
      From worker 3:    Stacktrace:                                                                                                                                              
      From worker 3:      [1] trsv!(uplo::Char, trans::Char, diag::Char, A::Matrix{Float64}, x::Vector{Float64})                                                                 
      From worker 3:        @ LinearAlgebra.BLAS /home/nanosoldier/.julia/scratchspaces/89f34f1a-2e6b-52eb-a20f-77051b03b735/workdir/jl_gwHnvM/julia/usr/share/julia/stdlib/v1.13
/LinearAlgebra/src/blas.jl:1383                                                                                                                                                  
      From worker 3:      [2] var"##core#802"(m#799::Matrix{Float64}, v#800::Vector{Float64}, n#801::Float64)                                                                    
      From worker 3:        @ BaseBenchmarks.LinAlgBenchmarks ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:598                                                        
      From worker 3:      [3] var"##sample#803"(::Tuple{Matrix{Float64}, Vector{Float64}, Float64}, __params::BenchmarkTools.Parameters)                                         
      From worker 3:        @ BaseBenchmarks.LinAlgBenchmarks ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:607
     From worker 3:      [4] _run(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; verbose::Bool, pad::String, warmup::Bool, kwargs::@Kwargs{samples::Int64, evals::In
t64, gctrial::Bool, gcsample::Bool})                                                                                                                                             
      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:113                                                                         
      From worker 3:      [5] invokelatest                                                                                                                                       
      From worker 3:        @ ./Base_compiler.jl:224 [inlined]                                                                                                                         From worker 3:      [6] #run_result#31                                                                                                                                     
      From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:48 [inlined]                                                                               
      From worker 3:      [7] run_result                                                                                                                                               From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:47 [inlined]                                                                               
      From worker 3:      [8] run(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; progressid::Base.UUID, nleaves::Int64, ndone::Int64, kwargs::@Kwargs{verbose::Bool, 
pad::String, samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool})                                                                                                             From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:143                                                                         
      From worker 3:      [9] run (repeats 2 times)                                                                                                                              
      From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:135 [inlined]                                                                              
      From worker 3:     [10] macro expansion                                                                                                                                    
      From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:163 [inlined]                                                                              
      From worker 3:     [11] macro expansion                                                                                                                                    
      From worker 3:        @ ./timing.jl:461 [inlined]                                                                                                                          
      From worker 3:     [12] (::BenchmarkTools.var"#38#39"{Bool, String, @Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool, progressid::Base.UUID, nleaves::In
t64, ndone::Int64}, BenchmarkGroup, Tuple{}})(progressid::Base.UUID, nleaves::Int64, ndone::Int64)                                                                                     From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:162                                                                               From worker 3:     [13] _withprogress(f::BenchmarkTools.var"#38#39"{Bool, String, @Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool, progressid::Base.UUI
D, nleaves::Int64, ndone::Int64}, BenchmarkGroup, Tuple{}}, name::String, group::BenchmarkGroup; progressid::Base.UUID, nleaves::Int64, ndone::Int64, ::@Kwargs{samples::Int64, e
vals::Int64, gctrial::Bool, gcsample::Bool})                                                                                                                                     
      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:90                                                                                From worker 3:     [14] run(::BenchmarkGroup; verbose::Bool, pad::String, kwargs::@Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool, progressid::Base.UUID, nleaves::Int64, ndone::Int64})                                                                                                                                                      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:152                                                                         
      From worker 3:     [15] run                                                                                                                                                
      From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:151 [inlined]                                                                              
      From worker 3:     [16] macro expansion                                                                                                                                    
      From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:163 [inlined]                                                                              
      From worker 3:     [17] macro expansion                                                                                                                                    
      From worker 3:        @ ./timing.jl:461 [inlined]                                                                                                                          
      From worker 3:     [18] (::BenchmarkTools.var"#38#39"{Bool, String, @Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool, progressid::Base.UUID, nleaves::In
t64, ndone::Int64}, BenchmarkGroup, Tuple{}})(progressid::Base.UUID, nleaves::Int64, ndone::Int64)
      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:162                                                                         
      From worker 3:     [19] _withprogress(f::BenchmarkTools.var"#38#39"{Bool, String, @Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool, progressid::Base.UUI
D, nleaves::Int64, ndone::Int64}, BenchmarkGroup, Tuple{}}, name::String, group::BenchmarkGroup; progressid::Base.UUID, nleaves::Int64, ndone::Int64, ::@Kwargs{samples::Int64, e
vals::Int64, gctrial::Bool, gcsample::Bool})
      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:90                                                                          
      From worker 3:     [20] run(::BenchmarkGroup; verbose::Bool, pad::String, kwargs::@Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool, progressid::Base.UUI
D, nleaves::Int64, ndone::Int64})
      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:152                                                                         
      From worker 3:     [21] macro expansion                                           
      From worker 3:        @ ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:163 [inlined]                                                                              
      From worker 3:     [22] macro expansion                                           
      From worker 3:        @ ./timing.jl:461 [inlined]                                 
      From worker 3:     [23] (::BenchmarkTools.var"#38#39"{Bool, String, @Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool}, BenchmarkGroup, Tuple{}})(progres
sid::Base.UUID, nleaves::Int64, ndone::Int64)
      From worker 3:        @ BenchmarkTools ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:162                                                                         
      From worker 3:     [24] _withprogress(f::BenchmarkTools.var"#38#39"{Bool, String, @Kwargs{samples::Int64, evals::Int64, gctrial::Bool, gcsample::Bool}, BenchmarkGroup, Tup

Note that you can run all of the benchmarks in a couple minutes if you run them as tests instead of as benchmarks locally to examine the error:
https://github.com/JuliaCI/BaseBenchmarks.jl/blob/06da8005d4872ed627b5fdfe7a9293448e291d08/test/runtests.jl#L11-L12