Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Base.bitcast(ty, v) to all packed isbits types. #57227

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Extend Base.bitcast(ty, v) to all packed isbits types. #57227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/datatype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,11 @@ int jl_datatype_isinlinealloc(jl_datatype_t *ty, int pointerfree)
return 0;
}

JL_DLLEXPORT int jl_datatype_has_padding(jl_datatype_t *dt)
{
return jl_is_datatype(dt) && dt->layout && dt->layout->flags.haspadding;
}

static unsigned union_isinlinable(jl_value_t *ty, int pointerfree, size_t *nbytes, size_t *align, int asfield)
{
if (jl_is_uniontype(ty)) {
Expand Down
5 changes: 5 additions & 0 deletions src/julia.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,6 +1611,11 @@ STATIC_INLINE int jl_is_primitivetype(void *v) JL_NOTSAFEPOINT
return (jl_is_datatype(v) && ((jl_datatype_t*)(v))->isprimitivetype);
}

STATIC_INLINE int jl_is_bitstype(void *v) JL_NOTSAFEPOINT
{
return (jl_is_datatype(v) && ((jl_datatype_t*)(v))->isbitstype);
}

STATIC_INLINE int jl_is_structtype(void *v) JL_NOTSAFEPOINT
{
return (jl_is_datatype(v) &&
Expand Down
1 change: 1 addition & 0 deletions src/julia_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,7 @@ void jl_init_main_module(void);
JL_DLLEXPORT int jl_is_submodule(jl_module_t *child, jl_module_t *parent) JL_NOTSAFEPOINT;
jl_array_t *jl_get_loaded_modules(void);
JL_DLLEXPORT int jl_datatype_isinlinealloc(jl_datatype_t *ty, int pointerfree);
JL_DLLEXPORT int jl_datatype_has_padding(jl_datatype_t *dt);
int jl_type_equality_is_identity(jl_value_t *t1, jl_value_t *t2) JL_NOTSAFEPOINT;

JL_DLLEXPORT void jl_eval_const_decl(jl_module_t *m, jl_value_t *arg, jl_value_t *val);
Expand Down
12 changes: 8 additions & 4 deletions src/runtime_intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,10 +392,14 @@ JL_DLLEXPORT BFLOAT16_TYPE julia__truncdfbf2(double param) JL_NOTSAFEPOINT
JL_DLLEXPORT jl_value_t *jl_bitcast(jl_value_t *ty, jl_value_t *v)
{
JL_TYPECHK(bitcast, datatype, ty);
if (!jl_is_concrete_type(ty) || !jl_is_primitivetype(ty))
jl_error("bitcast: target type not a leaf primitive type");
if (!jl_is_primitivetype(jl_typeof(v)))
jl_error("bitcast: value not a primitive type");
if (!jl_is_concrete_type(ty) || !jl_is_bitstype(ty))
jl_error("bitcast: target type not a leaf bits type");
if (!jl_is_bitstype(jl_typeof(v)))
jl_error("bitcast: value not a bits type");
if (jl_datatype_has_padding((jl_datatype_t*)(ty)))
jl_error("bitcast: target type has padding. Can only bitcast to packed types.");
if (jl_datatype_has_padding((jl_datatype_t*)(jl_typeof(v))))
jl_error("bitcast: value struct has padding. Can only bitcast from packed types.");
if (jl_datatype_size(jl_typeof(v)) != jl_datatype_size(ty))
jl_error("bitcast: argument size does not match size of target type");
if (ty == jl_typeof(v))
Expand Down