seed Dict so that hashes get non-zero h #57277
Open
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
needs tests
|
Why exactly is this needed? It's better to avoid advancing the random stream in various places, and it could also be quite surprising that every dict will put the same keys in a different order. Yes, you're not supposed to depend on the order, but it's surprising/weird. |
|
Yeah, not a fan of having Dict allocation become effectful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that we call the 2 arg
hashfromDictso that hashing functions can always rely on having entropy inhto help mix things up. This will obviously need testing and pkgeval to make sure it doesn't break any user expectations(which it really shouldn't)