Skip to content

Require Julia v1.10 (LTS) #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Require Julia v1.10 (LTS) #312

wants to merge 3 commits into from

Conversation

dlfivefifty
Copy link
Member

The motivation for this change would be to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10.

In particular, this makes it easier to finish #311

See also JuliaMath/AbstractFFTs.jl#140

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.91%. Comparing base (cefd827) to head (8a2fb50).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   70.99%   72.91%   +1.91%     
==========================================
  Files           5        5              
  Lines         531      528       -3     
==========================================
+ Hits          377      385       +8     
+ Misses        154      143      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member

I'm not sure this is strictly necessary for adding an extension: the extension would work only in Julia v1.9+, but can exist, without working also in previous releases. Requiring Julia v1.10 nowadays is a good idea regardless though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants