Fix type instability when h is a float#18
Open
maltezfaria wants to merge 1 commit intoJuliaMath:masterfrom
Open
Fix type instability when h is a float#18maltezfaria wants to merge 1 commit intoJuliaMath:masterfrom
h is a float#18maltezfaria wants to merge 1 commit intoJuliaMath:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 101 104 +3
=========================================
+ Hits 101 104 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On commit 41dc041, the following code errors on my machine:
while this one works
I poked around a bit, and it appears that type instability comes from the branch with
x0infinite, but I failed to really understand what was going on (I suspect it had something to do with the recursive call). This PR fixes the issue by factoring out the logic ofextrapolateinto an_extrapolatefunction that takes only positional arguments, thus avoiding the recursive call.