Skip to content

Reactant: try static cuda #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reactant: try static cuda #12363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions R/Reactant/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ include(joinpath(YGGDRASIL_DIR, "fancy_toys.jl"))

name = "Reactant"
repo = "https://github.com/EnzymeAD/Reactant.jl.git"
reactant_commit = "c3255d4e49fc12c2804d6a72d1b2e99129dbbfea"
reactant_commit = "029960d58f7a7ece750409bfac4a116815edc203"
version = v"0.0.252"
Comment on lines +9 to 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reactant_commit = "029960d58f7a7ece750409bfac4a116815edc203"
version = v"0.0.252"
reactant_commit = "c3255d4e49fc12c2804d6a72d1b2e99129dbbfea"
version = v"0.0.253"


sources = [
Expand Down Expand Up @@ -419,7 +419,7 @@ augment_platform_block="""
"""

# for gpu in ("none", "cuda", "rocm"), mode in ("opt", "dbg"), platform in platforms
for gpu in ("none", "cuda"), mode in ("opt", "dbg"), cuda_version in ("none", "12.6", "12.8", "13.0"), platform in platforms
for gpu in ("none", "cuda"), mode in ("opt", "dbg"), cuda_version in ("none", "12.8", "13.0"), platform in platforms

augmented_platform = deepcopy(platform)
augmented_platform["mode"] = mode
Expand Down Expand Up @@ -498,7 +498,7 @@ for gpu in ("none", "cuda"), mode in ("opt", "dbg"), cuda_version in ("none", "1
if arch(platform) == "aarch64" && gpu == "cuda"
if hermetic_cuda_version_map[cuda_version] == "13.0.0"
# bazel currentlty tries to run external/cuda_nvcc/bin/../nvvm/bin/cicc: line 1: ELF
continue
# continue

# See https://developer.download.nvidia.com/compute/cuda/redist/redistrib_13.0.0.json
push!(platform_sources,
Expand Down Expand Up @@ -552,24 +552,7 @@ for gpu in ("none", "cuda"), mode in ("opt", "dbg"), cuda_version in ("none", "1
if gpu == "cuda"
for lib in (
"libnccl",
"libcufft",
"libcudnn_engines_precompiled",
"libcudart",
"libcublasLt",
"libcudnn_heuristic",
"libcudnn_cnn",
"libnvrtc",
"libcudnn_adv",
"libcudnn",
"libnvJitLink",
"libcublas",
"libcudnn_ops",
"libnvrtc-builtins",
"libcudnn_graph",
"libcusolver",
# "libcuda",
"libcudnn_engines_runtime_compiled",
"libcusparse",
"libnvshmem_host",
"nvshmem_bootstrap_uid",
"nvshmem_transport_ibrc"
Expand Down
10 changes: 4 additions & 6 deletions R/Reactant/platform_augmentation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ else
end

const cuda_version_preference = if haskey(preferences, "cuda_version")
expected = ("none", "12.6", "12.8", "13.0")
expected = ("none", "12.8", "13.0")
if isa(preferences["cuda_version"], String) && preferences["cuda_version"] in expected
preferences["cuda_version"]
else
Expand Down Expand Up @@ -93,14 +93,12 @@ function augment_platform!(platform::Platform)
Libdl.dlclose(handle)

if cuda_version_tag == "none" && current_cuda_version isa VersionNumber
if v"12.6" <= current_cuda_version < v"12.8"
cuda_version_tag = "12.6"
elseif v"12.8" <= current_cuda_version < v"13"
if v"12" <= current_cuda_version < v"13"
cuda_version_tag = "12.8"
elseif v"13.0" <= current_cuda_version < v"14" && arch(platform) == "x86_64"
elseif v"13.0" <= current_cuda_version < v"14"
cuda_version_tag = "13.0"
else
@warn "CUDA version $(current_cuda_version) in $(path) not supported with this version of Reactant (min supported: 12.6)"
@warn "CUDA version $(current_cuda_version) in $(path) not supported with this version of Reactant (min supported: 12)"
end
end

Expand Down