Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenFHE: fix library install directory in CMake #7880

Merged
merged 2 commits into from
Dec 31, 2023
Merged

OpenFHE: fix library install directory in CMake #7880

merged 2 commits into from
Dec 31, 2023

Conversation

sloede
Copy link
Contributor

@sloede sloede commented Dec 31, 2023

cc @giordano

I will also attempt to figure out if this can be fixed upstream, i.e., that OpenFHE directly installs the .dll files to the correct location (bin/) such that this postfix is not necessary anymore.

@sloede sloede mentioned this pull request Dec 31, 2023
Merged
@sloede
Copy link
Contributor Author

sloede commented Dec 31, 2023

I believe the culprit is here:
https://github.com/openfheorg/openfhe-development/blob/b2869aef5cf61afd364b3eaea748dcc8a7020b9c/src/binfhe/CMakeLists.txt#L38
(similar for the other two libraries created by OpenFHE). It forces all library products to be installed in the lib dir, which is wrong on Windows systems. See also the sections on the DESTINATION and the GNUInstallDirs in https://cmake.org/cmake/help/latest/command/install.html#targets.

giordano
giordano reviewed Dec 31, 2023
View reviewed changes
O/OpenFHE/bundled/patches/windows-fix-cmake-libdir.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's presumably easier to patch the CMake file which installs the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes. Once I figured this out, I submitted an upstream patch (openfheorg/openfhe-development#634) and updated the PR here with the same patch. It would be great if we can merge this already now, and I'll update the build_tarballs.jl once an upstream fix has been released.

@sloede sloede changed the title OpenFHE: fix library path in CMake targets file OpenFHE: fix library install directory in CMake Dec 31, 2023
@giordano giordano merged commit 1210bc5 into JuliaPackaging:master Dec 31, 2023
@sloede sloede deleted the msl/openfhe-fix-cmake-windows branch December 31, 2023 13:29
MichelJuillard pushed a commit to MichelJuillard/Yggdrasil that referenced this pull request Jan 8, 2024
@sloede @MichelJuillard
OpenFHE: fix library install directory in CMake (JuliaPackaging#7880)
37e09e1 
* OpenFHE: fix library path in CMakeTargets file

* Properly fix the library install dir in upstream sources
grasph pushed a commit to Moelf/Yggdrasil that referenced this pull request Jul 1, 2024
@sloede @grasph
OpenFHE: fix library install directory in CMake (JuliaPackaging#7880)
fa0775e 
* OpenFHE: fix library path in CMakeTargets file

* Properly fix the library install dir in upstream sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloede @giordano