Support bind port hints #19
Conversation
JamesWrigley
force-pushed
the
multiple-workers
branch
from
f4c2a87 to
cdabed6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 88.17% 88.07% -0.11%
==========================================
Files 11 11
Lines 2081 2096 +15
==========================================
+ Hits 1835 1846 +11
- Misses 246 250 +4 ☔ View full report in Codecov by Sentry. |
JamesWrigley
force-pushed
the
multiple-workers
branch
from
cdabed6 to
7141706
Compare
|
(gentle bump) |
src/managers.jl
Outdated
| `[bind_addr[:bind_port]]` is specified, other workers will connect to this | ||
| worker at the specified `bind_addr` and `bind_port`. `bind_port` can be a | ||
| specific port like in `addr:9000`, but it can also specify a port hint by | ||
| enclosing it in brackets like `addr:[9000]`. |
There was a problem hiding this comment.
Is the definition "port hint" described anywhere else? If not, we should indicate what "port hint" actually means and what it does here (because I actually don't know what it does 😅).
There was a problem hiding this comment.
Sure, added in 4143d37 :) I use the same definition as Sockets.listenany().
Otherwise all the workers would try to bind to the same port, which would cause an error.
JamesWrigley
force-pushed
the
multiple-workers
branch
from
7141706 to
9550dcf
Compare
|
CI is failing on nightly at this line: DistributedNext.jl/test/distributed_exec.jl Line 1175 in f9cee85 If I understand correctly the test_exeflags variable is not being copied into the closure, or the closure isn't getting serialized correctly or something. I think it requires a bit more debugging so I won't hack around it for now. It's unrelated to this PR though (also happens on master) so I'll go ahead and merge.
|
Quick explanation:
addprocs([("machine 10.1.1.1:9000", 2)])by using the bind port as a port hint for all the other workers.Fixes [fakebreak] JuliaLang/Distributed.jl#119. If this is merged I'll backport it to Distributed.