Use unique temp file for installer to fix multi-user collision#270
Open
drewrobson wants to merge 1 commit intoJuliaPy:masterfrom
Open
Use unique temp file for installer to fix multi-user collision#270drewrobson wants to merge 1 commit intoJuliaPy:masterfrom
drewrobson wants to merge 1 commit intoJuliaPy:masterfrom
Conversation
On multi-user systems, the hardcoded `/tmp/installer.sh` path causes EPERM errors when one user's leftover file blocks another user due to the sticky bit on /tmp. Using `tempname()` generates a unique path per invocation, avoiding the collision entirely. Fixes JuliaPy#253 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 85.22% 84.84% -0.38%
==========================================
Files 1 1
Lines 203 198 -5
==========================================
- Hits 173 168 -5
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/installer.shpath causesEPERMerrors when one user's leftover file blocks another user due to the sticky bit on/tmpjoinpath(tempdir(), "installer.sh")withtempname(), which generates a unique path per invocation and avoids the collision entirelyFixes #253
Test plan
_install_conda)tempname()is a Julia stdlib function that returns a unique temporary file path, so no new dependencies are introduced🤖 Generated with Claude Code