Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for JuMP to 0.23, (keep existing compat) #2942

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the JuMP package from 0.21 - 0.22 to 0.21 - 0.22, 0.23.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@schillic schillic force-pushed the compathelper/new_version/2022-02-26-00-34-40-571-02292608867 branch from 80084cf to c65d791 Compare February 26, 2022 00:34
@schillic
Copy link
Member

It seems to me that the blocking comes from a chain of inconsistent package versions. The chain ultimately ends in Reexport, which itself is made inconsistent by DynamicPolynomials, which is a dependency of MultivariatePolynomials and TypedPolynomials, which finally use an old version of MutableArithmetics. I reported that here.

@schillic
Copy link
Member

The dependency issues are now all resolved. Now we need to fix the breaking change(s) in the tests.

@schillic schillic force-pushed the compathelper/new_version/2022-02-26-00-34-40-571-02292608867 branch from 6883cfd to 618acbb Compare February 27, 2022 18:51
@schillic schillic marked this pull request as draft February 27, 2022 19:57
@schillic
Copy link
Member

The test failure is caused by a behavioral change in JuMP v0.22 that was only uncovered now (that JuMP version was held back by other packages before). I asked about that change in jump-dev/JuMP.jl#2894.

@schillic
Copy link
Member

The JuMP issue was fixed, but we were advised to not use Rationals with JuMP and also to not use infinite bounds. We should discuss this (but not here).

@schillic schillic force-pushed the compathelper/new_version/2022-02-26-00-34-40-571-02292608867 branch from b6b5040 to 1dc58b2 Compare March 4, 2022 06:33
@schillic schillic marked this pull request as ready for review March 4, 2022 07:12
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mforets: The relevant change here is that I commented out the ICP tests because the package seems to be incompatible now. I suggest to support the new JuMP family instead.

@schillic schillic mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants