-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for JuMP to 0.23, (keep existing compat) #2942
CompatHelper: bump compat for JuMP to 0.23, (keep existing compat) #2942
Conversation
80084cf
to
c65d791
Compare
It seems to me that the blocking comes from a chain of inconsistent package versions. The chain ultimately ends in |
The dependency issues are now all resolved. Now we need to fix the breaking change(s) in the tests. |
6883cfd
to
618acbb
Compare
The test failure is caused by a behavioral change in |
The |
b6b5040
to
1dc58b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mforets: The relevant change here is that I commented out the ICP
tests because the package seems to be incompatible now. I suggest to support the new JuMP
family instead.
This pull request changes the compat entry for the
JuMP
package from0.21 - 0.22
to0.21 - 0.22, 0.23
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.