Skip to content

Conversation

@ericphanson
Copy link
Member

@ericphanson ericphanson commented Oct 20, 2025

closes #603, code copied from that issue via claude

based on #631 which should be merged first

ericphanson and others added 15 commits September 30, 2025 16:37
This reverts commit ea0b155.
Implements validation to ensure package UUIDs conform to RFC 4122/RFC 9562
standards. The check validates:
- Version field (bits 48-51) is 1-8
- Variant field (bits 64-65) is binary 10 (hex 8, 9, a, or b)

Special handling for Julia's historically buggy uuid1() implementation,
which set variant bits to 00 instead of 10. These legacy v1 UUIDs are
accepted for backward compatibility.

Fixes #603

Co-Authored-By: Claude <[email protected]>
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.13%. Comparing base (3e3628f) to head (d0bdee8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
AutoMerge/src/guidelines.jl 92.85% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (48.13%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (3e3628f) and HEAD (d0bdee8). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (3e3628f) HEAD (d0bdee8)
24 11
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #642       +/-   ##
===========================================
- Coverage   78.25%   48.13%   -30.12%     
===========================================
  Files          29       29               
  Lines        1922     1928        +6     
===========================================
- Hits         1504      928      -576     
- Misses        418     1000      +582     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from eph/fix-check to master October 20, 2025 20:32
@ericphanson ericphanson dismissed GunnarFarneback’s stale review October 20, 2025 20:33

The base branch was changed.

@ericphanson ericphanson enabled auto-merge October 20, 2025 20:41
@ericphanson ericphanson added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@ericphanson
Copy link
Member Author

rate limited: https://github.com/JuliaRegistries/RegistryCI.jl/actions/runs/18664442749/job/53213074971#step:9:4227

Status Code: 403
Message: API rate limit exceeded for user ID 57020912. If you reach out to GitHub Support for help, please include the request ID 3004:21731D:1F624A8:852F31A:68F6A63B and timestamp 2025-10-20 21:14:35 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service)
Docs URL: https://docs.github.com/rest/overview/rate-limits-for-the-rest-api

we need JuliaWeb/GitHub.jl#233 !

@ericphanson ericphanson added this pull request to the merge queue Oct 21, 2025
Merged via the queue into master with commit 9818af3 Oct 21, 2025
15 of 17 checks passed
@ericphanson ericphanson deleted the eph/sanity-check-uuid branch October 21, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutoMerge feature request: Sanity check uuid for new packages

3 participants