-
Notifications
You must be signed in to change notification settings - Fork 32
add UUID sanity check #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Claude <[email protected]>
This reverts commit ea0b155.
Implements validation to ensure package UUIDs conform to RFC 4122/RFC 9562 standards. The check validates: - Version field (bits 48-51) is 1-8 - Variant field (bits 64-65) is binary 10 (hex 8, 9, a, or b) Special handling for Julia's historically buggy uuid1() implementation, which set variant bits to 00 instead of 10. These legacy v1 UUIDs are accepted for backward compatibility. Fixes #603 Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (48.13%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
===========================================
- Coverage 78.25% 48.13% -30.12%
===========================================
Files 29 29
Lines 1922 1928 +6
===========================================
- Hits 1504 928 -576
- Misses 418 1000 +582 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The base branch was changed.
|
rate limited: https://github.com/JuliaRegistries/RegistryCI.jl/actions/runs/18664442749/job/53213074971#step:9:4227
we need JuliaWeb/GitHub.jl#233 ! |
closes #603, code copied from that issue via claude
based on #631 which should be merged first