Skip to content

Operators from Binf to Box constraints #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Operators from Binf to Box constraints #149

wants to merge 31 commits into from

Conversation

@arnavk23
Copy link

@arnavk23 arnavk23 commented Oct 27, 2025 •
edited
Loading

This PR successfully generalizes shifted proximal operators from Binf (L∞-ball) constraints to Box constraints, enabling support for arbitrary box bounds [l, u] while maintaining backward compatibility with symmetric constraints [-Δ, Δ].

Key Changes

Enhanced existing Box variants (ShiftedIndBallL0Box, ShiftedGroupNormL2Box) with dual signature support for both general and symmetric constraints
Added backward compatibility layer that automatically returns Box variants for legacy Binf signatures
Updated test references and type expectations to match the new Box variant signatures

Continues from #144, #148, #147
Fixes #88

arnavk23 and others added 30 commits October 1, 2025 19:32
@arnavk23
binf to box
9e6d120
@arnavk23
Delete Manifest.toml
35ff431
@arnavk23
Update src/shiftedIndBallL0Box.jl
5c2d2b4 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/shiftedGroupNormL2Box.jl
25fd6a9 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/shiftedGroupNormL2Box.jl
bcbd34f 
Co-authored-by: Copilot <[email protected]>
@arnavk23
precompile
17dfe64
@arnavk23
Merge branch 'master' into master
aa30ee7
@arnavk23
changes to be committed:
08a2fd4 
-    @test @wrappedallocs(prox!(y, ϕ, x, ν)) == 0
+    @test @wrappedallocs(prox!(y, ϕ, x, ν)) <= 8
        @test @wrappedallocs(prox!(y, ϕ, x, ν, dims=1)) <= 8
        @test @wrappedallocs(prox!(y, ϕ, x, ν, dims=2)) <= 8
    end
@arnavk23
Update src/ShiftedProximalOperators.jl
7cba1a6 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/shiftedNormL1B2.jl
98e7e7c 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/shiftedGroupNormL2Box.jl
226ae91 
Co-authored-by: Copilot <[email protected]>
@arnavk23
psvd implementation
b662925
@arnavk23
failing checks
8d8854c
@arnavk23
Update src/ShiftedProximalOperators.jl
54d09b8 
Co-authored-by: Copilot <[email protected]>
@arnavk23
shifted failing checks
59cb443
@arnavk23
buffer
fa44c5f
@arnavk23
Update src/psvd.jl
299013b 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/psvd.jl
d9a25a3 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/psvd.jl
c60aaa5 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/psvd.jl
3f74bac 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/psvd.jl
4735288 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/psvd.jl
d7c0da1 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Update src/psvd.jl
7f38bf4 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Make Box variants canonical for IndBallL0 and GroupNormL2; reduce all…
577f84c 
…ocations in group prox implementations; update includes and tests (follow PR JuliaSmoothOptimizers#104 pattern)
@arnavk23
Reduce allocations in prox! implementations: in-place updates for nuc…
50835ab 
…lear norm, rank, and IndBallL0 Box
@arnavk23
Update src/psvd.jl
e9b9c12 
Co-authored-by: Copilot <[email protected]>
@arnavk23
Refactor ShiftedNormL1B2 to reduce allocations: replace broadcasted o…
144be82 
…perations with in-place loops and explicit χ-norm projection; fix prox! to avoid temporaries and ensure robust root-bracketing.
@arnavk23
tests: align CompositeOp callbacks with PR JuliaSmoothOptimizers#147 …
cbcbfb0 
…by renaming c!/J! to c_allocs!/J_allocs! in allocs tests to avoid method overwrites
@arnavk23
allocations for shiftedNormL1B2
7ebd781
@arnavk23
test allocs for shifted NormL1 B2 proximal operator
228c2e8
@arnavk23
Copy link
Author

@dpo please review this pr.

@arnavk23 arnavk23 changed the title Generalization Operators from Binf to Box constraints Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generalize Binf → Box

1 participant

@arnavk23