Skip to content

Conversation

@nickrobinson251
Copy link
Member

@nickrobinson251 nickrobinson251 commented Apr 2, 2025

Before output looked like e.g.

    •  is_eq has owner RAIIR but it was imported from RAIBackIR at src/Quxbaz.jl:44:14
Screenshot 2025-04-02 at 14 23 43

whereas now it looks like

    •  is_eq has owner RAI_IR but it was imported from RAI_BackIR at src/Qux_baz:44:14
Screenshot 2025-04-02 at 14 23 18

--

Also fix a precompile warning

so that names with `_` don't cause italics.
In the REPL `err` is abiguous so generates warning:
```
Precompiling ExplicitImports
┌ Warning: Assignment to `err` in soft scope is ambiguous because a global variable by the same name exists: `err` will be treated as a new local. Disambiguate by using `local err` to suppress this warning or `global err` to assign to the existing global variable.
└ @ ~/repos/ExplicitImports.jl/src/precompile.jl:7
```
@ericphanson
Copy link
Member

it looks like there are some more to quote in https://github.com/ericphanson/ExplicitImports.jl/blob/main/src/checks.jl

Do you mind also quoting source paths? i.e. row.location. That would fix #104 too

@nickrobinson251 nickrobinson251 changed the title Print module names wrapped in backticks so that names with _ don't cause italics Print modules and files wrapped in backticks so that names with _ don't cause italics Apr 3, 2025
Copy link
Member

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, ty!

@ericphanson ericphanson merged commit bbccb3b into JuliaTesting:main Apr 3, 2025
5 of 6 checks passed
@nickrobinson251
Copy link
Member Author

thanks for the quick merge and release, Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants