vendor AbstractTrees #123
Merged
vendor AbstractTrees #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO this is much less important than JuliaSyntax but the cost of vendoring 1 more dependency-free package is not high (need to run the update script sometimes anyway for JuliaSyntax) and this will prevent compat issues if AbstractTrees has a breaking release. So I think I will merge it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #121
Note we could avoid some of the Wrapper stuff that we did in parsing just to avoid piracy, since adding methods to this AbstractTrees would not be piracy. However I'd rather leave everything the same so we could unvendor easily if we wanted to.
We haven't had specific issues with AbstractTrees but I do like the idea of ExplicitImports having no external compat restrictions so in its app usage or similar it can analyze any package (even a hypothetical AbstractTrees v0.5).
This leaves only PrecompileTools, Pkg, Markdown, and TOML as deps. We could vendor Markdown and TOML but I don't think there's currently really any benefit as we do not have restrictive compatibility needs with them (and I don't think they are freely upgradable yet anyway). I don't think we should vendor PrecompileTools or Pkg as they need Julia-version-specific functionality.
So this PR would close the loop on vendoring/compatibility/deps at this point.