Skip to content

Lock request context changes during read/write spawned tasks #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2023

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented May 13, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #1046 (ff7db8d) into master (9c1d42a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
+ Coverage   85.22%   85.24%   +0.01%     
==========================================
  Files          32       32              
  Lines        3025     3029       +4     
==========================================
+ Hits         2578     2582       +4     
  Misses        447      447              
Impacted Files Coverage Δ
src/clientlayers/StreamRequest.jl 95.69% <100.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@quinnj quinnj merged commit a064940 into master May 13, 2023
@quinnj quinnj deleted the jq-lock-read-write-context branch May 13, 2023 14:04
@msagarpatel
Copy link

Hey @quinnj, should the accesses of res.request.context in readbody!() be guarded by the lock as well?

@quinnj
Copy link
Member Author

quinnj commented May 13, 2023

Hey @quinnj, should the accesses of res.request.context in readbody!() be guarded by the lock as well?

Great catch; thanks for the review @msagarpatel. PR up: #1048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants