Add content auto decoding for download()
#986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
- Coverage 82.53% 82.45% -0.09%
==========================================
Files 37 37
Lines 3040 3043 +3
==========================================
Hits 2509 2509
- Misses 531 534 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
quinnj
reviewed
Jan 12, 2023
src/download.jl
Outdated
| @@ -121,6 +123,11 @@ function download(url::AbstractString, local_path=nothing, headers=Header[]; upd | |||
| start_time = now() | |||
| prev_time = now() | |||
|
|
|||
| if header(resp, "Content-Encoding") == "gzip" | |||
| stream = TranscodingStream(GzipDecompressor(), stream) # auto decoding | |||
There was a problem hiding this comment.
I think this can just be:
Suggested change
| stream = TranscodingStream(GzipDecompressor(), stream) # auto decoding | |
| stream = GzipDecompressorStream(stream) # auto decoding |
and then we don't need the explicit dependency on TranscodingStreams
There was a problem hiding this comment.
Thank you. I fixed.
AtsushiSakai
commented
Jan 13, 2023
| @@ -13,6 +13,7 @@ include(joinpath(dir, "resources/TestRequest.jl")) | |||
| "chunking.jl", | |||
| "utils.jl", | |||
| "client.jl", | |||
| "download.jl", | |||
There was a problem hiding this comment.
I found this test file is missing.
AtsushiSakai
commented
Jan 13, 2023
| if header(resp, "Content-Encoding") == "gzip" | ||
| filename *= ".gz" | ||
| end | ||
|
|
There was a problem hiding this comment.
Auto decoding is added, so I think ".gz" is not needed anymore. And this change is needed to pass "test/download.jl".
quinnj
approved these changes
Jan 13, 2023
|
Thanks @AtsushiSakai! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds content auto decoding function for
download()using TranscodingStreams.jl to fix #889