Ensure we hold the IO lock when calling keepalive in libuv #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a private report of a segfault stemming from our call to `uv_tcp_keepalive`, which is now enabled by default since the 1.7 release.
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 85.39% 85.40%
=======================================
Files 37 37
Lines 3054 3055 +1
=======================================
+ Hits 2608 2609 +1
Misses 446 446
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a private report of a segfault stemming from our call to
uv_tcp_keepalive, which is now enabled by default since the 1.7 release.