Refactor code a bit to reduce allocations and dynamic dispatches #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Together with JuliaWeb/HTTP.jl#985, this reduces allocations on a typical request by about ~100. The main wins here are hard-coding TCPSocket as the `io` field of `SSLStream` (which we assume anyway), and changing the `geterror` function to a macro to avoid the closure boxing problem.
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 75.33% 75.80% +0.47%
==========================================
Files 2 2
Lines 1046 1050 +4
==========================================
+ Hits 788 796 +8
+ Misses 258 254 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with JuliaWeb/HTTP.jl#985, this reduces allocations on a typical request by about ~100. The main wins here are hard-coding TCPSocket as the
iofield ofSSLStream(which we assume anyway), and changing thegeterrorfunction to a macro to avoid the closure boxing problem.