Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week2_assingnment #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

week2_assingnment #1

wants to merge 1 commit into from

Conversation

ahmetinan79
Copy link

No description provided.

@ahmetinan79 ahmetinan79 changed the title Add files via upload week2_assingnment Oct 22, 2020
@Fatiherik
Copy link
Contributor

Fatiherik commented Nov 11, 2020

  • style kodlarini ayri bir css dosyasinda yazman,
  • kodlarin semantik duzeninin iyi olmasi
  • id ve class isimlerinin anlasilir olmasi,
  • ve css kodlarini section section ayirman cok guzel, istedigimiz tam olarak bunlardi ve hepsini yapmissin, tebrikler:)

Oneri olarak,

  • id ve class isimlerinin basina section, div yazmana gerek yok, genelde yazilmiyor,
  • style kodlarinin basina bir tab koyarsan daha profesyonel durur. Asagidaki gibi,

.section {
(tab)color:red;
(tab)padding:10px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants