Add BUILD_STATIC option to create static libraries #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
force-pushed
the
drdanz/static_libs
branch
from
9a8f735 to
95d2f4c
Compare
iamsergio
approved these changes
Dec 10, 2024
|
This should use option BUILD_SHARED_LIBS instead. |
dantti
reviewed
Dec 10, 2024
| @@ -76,6 +79,13 @@ else() | |||
| option(BUILD_TESTS "Build the test harness" ON) | |||
| endif() | |||
| option(BUILD_QT6 "Build against Qt 6" OFF) | |||
| option(BUILD_STATIC "Build statically" OFF) | |||
There was a problem hiding this comment.
option(BUILD_SHARED_LIBS "Build in shared lib mode" ON)
There was a problem hiding this comment.
That make sense, but I've been following the same policies used in the other KD* repository that I'm currently packaging for vcpkg, I don't know why BUILD_SHARED_LIBS isn't used anywhere else...
| @@ -76,6 +79,13 @@ else() | |||
| option(BUILD_TESTS "Build the test harness" ON) | |||
| endif() | |||
| option(BUILD_QT6 "Build against Qt 6" OFF) | |||
| option(BUILD_STATIC "Build statically" OFF) | |||
|
|
|||
| if(BUILD_STATIC) | |||
| @@ -77,7 +77,7 @@ if(GRAPHVIZ_FOUND) | |||
| endif() | |||
| endif() | |||
|
|
|||
| add_library(kdstatemachineeditor_core SHARED ${LIB_SRCS}) | |||
| add_library(kdstatemachineeditor_core ${BUILD_LIBRARY_MODE} ${LIB_SRCS}) | |||
There was a problem hiding this comment.
also not needed here just add_library(kdstatemachineeditor_core ${LIB_SRCS})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.