Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cmake options #77

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Rename cmake options #77

merged 1 commit into from
Dec 11, 2024

Conversation

drdanz
Copy link
Contributor

@drdanz drdanz commented Dec 11, 2024

Following the conventions used in the other KD* repositories, use variables with a name that start with the project name.

Renamed options:

  • BUILD_DOCS -> KDSME_DOCS
  • BUILD_EXAMPLES -> KDSME_EXAMPLES
  • BUILD_QT6 -> KDSME_QT6
  • WITH_INTERNAL_GRAPHVIZ -> KDSME_INTERNAL_GRAPHVIZ
  • WITH_STATIC_GRAPHVIZ -> KDSME_STATIC_GRAPHVIZ

Use standard cmake options instead of custom ones:

  • BUILD_TESTS -> BUILD_TESTING
  • BUILD_STATIC -> BUILD_SHARED_LIBS

Cache entries are automatically updated.

@drdanz drdanz force-pushed the drdanz/rename_options branch 4 times, most recently from 73ce6ee to ee50daf Compare December 11, 2024 13:04
Following the conventions used in the other KD* repositories, use
variables with a name that start with the project name.

Renamed options:

 * BUILD_DOCS -> KDSME_DOCS
 * BUILD_EXAMPLES -> KDSME_EXAMPLES
 * BUILD_QT6 -> KDSME_QT6
 * WITH_INTERNAL_GRAPHVIZ -> KDSME_INTERNAL_GRAPHVIZ
 * WITH_STATIC_GRAPHVIZ -> KDSME_STATIC_GRAPHVIZ

Use standard cmake options instead of custom ones:

 * BUILD_STATIC -> BUILD_SHARED_LIBS
 * BUILD_TESTS -> BUILD_TESTING

Cache entries are automatically updated.
@drdanz drdanz force-pushed the drdanz/rename_options branch from ee50daf to f00f81c Compare December 11, 2024 13:06
@iamsergio iamsergio merged commit 648e420 into master Dec 11, 2024
29 checks passed
@iamsergio iamsergio deleted the drdanz/rename_options branch December 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants