Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#43 icon 파일 형식 변경 #56

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

Dobbymin
Copy link
Collaborator

📝 상세 내용

기존의 svg 파일로 가져왔던 icon 들을 radix-ui 라이브러리의 아이콘으로 교체

#️⃣ 이슈 번호

🔗 참고 자료

📷 스크린샷(선택)

아이콘들 굵기가 달라서 확인 한번 부탁드립니다!

[변경 전]
image

[변경 후]
image

@Dobbymin Dobbymin added the 🎨 desgin HTML, CSS 등 UI 구현 label Dec 19, 2024
Copy link
Collaborator

@joojjang joojjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 :)
라벨은 라이브러리를 추가했으니 design보단 chore로 하는 게 어떤가요
PR 제목 바꾸어주시고용

Copy link
Member

@ppochaco ppochaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음부터 브랜치명은 영어로만 작성해주세용

@ppochaco ppochaco linked an issue Dec 19, 2024 that may be closed by this pull request
1 task
@Dobbymin Dobbymin changed the title Fix(main): footer 아이콘들 radix-ui로 변경 issue#43 icon 파일 형식 변경 Dec 19, 2024
@Dobbymin Dobbymin self-assigned this Dec 19, 2024
@joojjang joojjang added 📦 chore 기능상 변동이 없는 변경 and removed 🎨 desgin HTML, CSS 등 UI 구현 labels Dec 19, 2024
@ppochaco ppochaco merged commit 4b5e2f8 into develop Dec 20, 2024
1 check passed
@ppochaco ppochaco deleted the feature/#43-radix-icon-변경 branch December 20, 2024 08:18
@ppochaco ppochaco removed their assignment Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 chore 기능상 변동이 없는 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

radix icon 변경
3 participants