Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#57 #64

Merged
merged 10 commits into from
Aug 24, 2024
Merged

Issue/#57 #64

merged 10 commits into from
Aug 24, 2024

Conversation

momnpa333
Copy link
Collaborator

@momnpa333 momnpa333 commented Aug 24, 2024

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

์ด๋ฏธ์ง€ ์ฒจ๋ถ€

์‹คํŒจํ•œ ํ…Œ์ŠคํŠธ๊ฐ€ ์žˆ์„๋•Œ ์ด๋ฏธ์ง€ ์ฒจ๋ถ€

image image

์ž๋™์œผ๋กœ ์‹คํŒจํ•œ ์ปค๋ฐ‹์—์„œ ์ฝ”๋ฉ˜ํŠธ๋ฅผ ๋‚จ๊ธฐ๋Š” ๊ธฐ๋Šฅ ๊ตฌํ˜„

To Reviewers ๐Ÿ“ข

ci์—์„œ ์ฝ”๋ฉ˜ํŠธ๋ฅผ ๋‚จ๊ธฐ๊ธฐ ์œ„ํ•ด ๊ถŒํ•œ์„ค์ •์„ ๋ฐ”๊ฟจ์Šต๋‹ˆ๋‹ค. ์ƒ๊ด€ ์—†๊ฒ ์ฃ ?
ํ…Œ์ŠคํŠธ๊ฐ€ ์‹คํŒจํ–ˆ์„๋•Œ ๋‹ค์‹œ ํ…Œ์ŠคํŠธ๊ฐ€ ์„ฑ๊ณตํ•˜๊ฒŒ๋” commit์„ ์ƒˆ๋กœ ๋‚ ๋ฆฌ๋ฉด Unit Test Results ์ฐฝ์ด ์ž๋™์œผ๋กœ ๋ฐ”๋€๋‹ˆ๋‹ค.->PR ์ƒˆ๋กœ ๋‚ ๋ฆด ํ•„์š” ์—†์–ด์—ฌ

test์šฉ yml ๋ถ„๋ฆฌ ํ–ˆ์Šต๋‹ˆ๋‹ค

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

Copy link

github-actions bot commented Aug 24, 2024

Unit Test Results

27 testsโ€‚โ€ƒโ€ƒ27 โœ”๏ธโ€ƒโ€ƒ2s โฑ๏ธ
โŸโ€„7 suitesโ€ƒโ€ƒโŸโ€„0 ๐Ÿ’ค
โŸโ€„7 filesโ€„โ€‚โ€ƒโ€ƒโŸโ€„0 โŒ

Results for commit 2052f5b.

โ™ป๏ธ This comment has been updated with latest results.

@momnpa333 momnpa333 self-assigned this Aug 24, 2024
Copy link
Collaborator

@bayy1216 bayy1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!
์ด๊ฑฐ๋Š” ์ €๋„ ์ž˜ ๋ชฐ๋ผ์„œ ๊ทธ๋Ÿฐ๋ฐ(์ง€๊ธˆ๋„ ์ข‹์•„์š”)

PR์‹œ์— ์•ก์…˜ํŒŒ์ผ์„ ํ…Œ์ŠคํŠธ๋งŒ ์ง„ํ–‰ํ•˜๋Š” yml,
๋ฉ”์ธ ๋ธŒ๋žœ์น˜์— MERGE์‹œ์— ํ…Œ์ŠคํŠธ&๋นŒ๋“œ&๋ฐฐํฌ ํ•˜๋Š” yml๋กœ ๋ถ„๋ฆฌํ•˜๋Š” ๋ฐฉ์‹์€ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?!

@momnpa333
Copy link
Collaborator Author

์Œ yml์„ ๋ถ„๋ฆฌํ•˜๋Š”๊ฒŒ ๋” ์ ์ ˆํ•ด ๋ณด์ด๋„ค์—ฌ ๋ถ„๋ฆฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ด

@momnpa333
Copy link
Collaborator Author

๋ถ„๋ฆฌ ํ–ˆ์Šต๋‹ˆ๋‹ด!

@bayy1216 bayy1216 merged commit 5e33899 into main Aug 24, 2024
3 checks passed
@bayy1216 bayy1216 deleted the issue/#57 branch August 24, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๊ฐœ๋ฐœ์šฉ branch PR์‹œ test ๊ฒ€์‚ฌ ๊ตฌํ˜„
2 participants