Skip to content

[Poker] Add more interesting events #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Poker] Add more interesting events #574

wants to merge 2 commits into from
+44 −4

Conversation

@chris-dmello
Copy link
Member

@chris-dmello chris-dmello commented Nov 21, 2025 •
edited
Loading

The follow interesting events are now displayed, in order:

  1. Upsets (Winner had <20% odds at turn or river) - New
  2. High Hand (Full House, Four of a Kind, Straight Flush, or Royal Flush - New
  3. All-in showdown (Both players go all-in) - New
  4. Big Pot - I increased threshold to 350 to reduce the number of highlights, which was getting a bit out of hand.

@develra
Copy link
Contributor

develra commented Nov 21, 2025

These seem great - thanks! If we still have too many I might drop big pot all together and just keep the other 3, or only select like the top 10 or something.

develra
develra reviewed Nov 21, 2025
View reviewed changes
web/core/src/transformers/repeated_poker/v2/repeatedPokerTransformerV2.ts
};

export const getPokerStepInterestingEvents = (gameSteps: RepeatedPokerStep[]): InterestingEvent[] => {
console.log(gameSteps);
Copy link
Contributor

@develra develra Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@develra develra develra approved these changes

@dominoweir dominoweir Awaiting requested review from dominoweir

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-dmello @develra