Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduced SDL changes for new kbd API. #100

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Reintroduced SDL changes for new kbd API. #100

merged 3 commits into from
Mar 1, 2025

Conversation

gyrovorbis
Copy link
Member

@gyrovorbis gyrovorbis commented Feb 18, 2025

Here's the revived PR for the SDL keyboard changes that are required for the new keyboard API work: KallistiOS/KallistiOS#503.

PLEASE NOTE: The version guards currently assume KOS_VERSION(2, 1, 1). Make sure they are changed to match whichever version this makes it into!

Talked to @QuzarDC and ensured it's now targetting KOS 2.2.0!

@gyrovorbis gyrovorbis added the update Updating existing functionality label Feb 18, 2025
Copy link
Member

@QuzarDC QuzarDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny things.

Copy link
Member

@QuzarDC QuzarDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Lets try this again! I figure to leave it for a bit before the KOS changes just to leave more chance for others to get it in and not have to deal with reports of SDL not linking.

@QuzarDC QuzarDC merged commit 5c5613b into master Mar 1, 2025
@QuzarDC QuzarDC deleted the kbd_update_2 branch March 1, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update Updating existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants