Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI redone #84

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

UI redone #84

wants to merge 7 commits into from

Conversation

SyonKuppili
Copy link
Contributor

Hey Kendall!

I finished re-doing the UI for this website. Hope you like it!

Thanks,
Syon Kuppili

accesslint[bot]
accesslint bot reviewed Feb 28, 2024
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

index.html
<h2 id="desc1">es spanning various</h2>
<h2 id="desc2">nge yourself with</h2>
<h2 id="desc3">e. Dive into a world</h2>
<h2 id="desc4"></h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headings shouldn't be empty.

KendallDoesCoding
KendallDoesCoding requested changes Feb 13, 2025
View reviewed changes
Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Thanks Syon.

I don't really like the front page UI. The quiz pages look good. Can we do anything about the front page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

@KendallDoesCoding KendallDoesCoding KendallDoesCoding requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyonKuppili @KendallDoesCoding