Feature: Dont mount table row component of detail panel when not expanded #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EdwardEB is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
Currently, I'm using this setup to solve the issue: Basically, passing this prop to renderDetailPanel: detailPanel ? ({ row }) => (row.getIsExpanded() ? detailPanel?.(row) : null) : undefined, |
|
This was done on purpose to avoid issues with both virtualization and striped row css |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, table row component would mount even if detail row is not expanded. This can cause the DOM to bloat rapidly.
A grid with 100 rows and a detail panel would create 100 extra DOM nodes.
Also fixed all detail panel stories.