Fix a bug where teams aren't added as reviewers when the author comments and the author is on the reviewer team #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lillialexis
changed the title
lillialexis
changed the title
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
lillialexis
added a commit
to Khan/actions
that referenced
this pull request
Jun 12, 2024
## Summary: See [this PR](Khan/gerald#87) with a bug-fix regarding GitHub teams not getting added when author is a member of that team, and the author adds comments. Point this to that, once it's landed and tagged. I also updated the README with instructions (mostly for myself, because I forgot what I did last time) on how to test PRs in this repo _before_ landing (and publishing). Issue: XXX-XXXX ## Test plan: Author: lillialexis Reviewers: jeresig, lillialexis Required Reviewers: Approved By: jeresig Checks: ✅ Lints, ✅ gerald Pull Request URL: #91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, when Gerald would run, it wouldn't add a team to the reviewer list if any member of the team had already reviewed the PR.
The problem is that PR authors can add comments to their PRs, and those are "review" objects. So, if an author makes a draft PR, adds some comments, clicks "Ready for review", and the author is a member of a team that Gerald would add, Gerald wouldn't add that team.
Very sneaky bug!! This fixes that. It still adds the team if the author commented (or any team member added a non-approving, non-rejecting review, such as a comment, or a pending review).
Issue: https://khanacademy.atlassian.net/browse/FEI-5620
Test plan:
Buggy case:
Fixed cases:
Fixed cases:
Fixed cases:
Some test PRs:
https://github.com/Khan/our-lovely-cli/pull/673
https://github.com/Khan/our-lovely-cli/pull/674
https://github.com/Khan/our-lovely-cli/pull/675