Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version in example file to use Khan/actions@gerald-pr-v3 #88

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

lillialexis
Copy link
Member

@lillialexis lillialexis commented Jun 12, 2024

Summary:

This points the example file to the version that fixes bug FEI-5620.

I should have included this in my last PR... I might re-point the currently tagged version to this sha when I land, so that tip of main isn't ahead of the last tag.

Issue: FEI-5620

Test plan:

See that the bug is fixed in this repo by having a Gerald-added-team-member comment on a draft PR then promote it

@lillialexis lillialexis self-assigned this Jun 12, 2024
@@ -13,7 +13,7 @@ jobs:
if: "github.event.action != 'edited' || github.event.changes.base != null"
runs-on: ubuntu-latest
steps:
- uses: Khan/actions@gerald-pr-v2
- uses: Khan/actions@gerald-pr-v3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

@lillialexis lillialexis marked this pull request as ready for review June 12, 2024 20:13
@khan-actions-bot khan-actions-bot requested a review from a team June 12, 2024 20:13
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/github-actions for changes to setup-files/gerald-pr.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@lillialexis lillialexis merged commit 6626012 into main Jun 20, 2024
6 checks passed
@lillialexis lillialexis deleted the FEI-5620 branch June 20, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants