Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ShouldNodeExport" hook #767

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Aug 26, 2024

Example usage:

    public override bool ShouldNodeExport(GLTFSceneExporter exporter, GLTFRoot gltfRoot, Transform transform)
    {
        Type[] excludedTypes =
        {
            typeof(FooBar),
            typeof(BarBaz)
        };
        bool hasExcludedComponent = excludedTypes.Any(t => transform.GetComponent(t) != null);
        return !hasExcludedComponent;
    }

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024

CLA assistant check
All committers have signed the CLA.

@andybak andybak marked this pull request as ready for review August 29, 2024 10:11
@andybak
Copy link
Contributor Author

andybak commented Feb 9, 2025

I've just hit a need for a similar method for Import. Does that belong in the same PR?

Is there anything missing that would help move this PR forward? We're a branch including this PR in production now.

@hybridherbst
Copy link
Collaborator

We're looking at the PR again and looks like it will be included with the next version :) We did add a big warning to the Readme that using this hook requires understanding what can go wrong because it's rather easy to shoot yourself in the foot (e.g. skipping export of a few bones in a hierarchy).

@hybridherbst
Copy link
Collaborator

Would be great if you take a look at that then and yes, feel free to make a new PR for import functionality!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants