-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Offer multiple choices for Vulkan C headers #2075
Conversation
@M2-TE Your change generated build failures on gitlab.khronos.org/vulkan:
Any idea how to resolve that? |
@asuessenbach Would this not indicate that the Vulkan-Headers submodule has not been pulled? If both this and FindVulkan are missing, how were the Vulkan C headers acquired before? I sadly do not think I have access to gitlab.khronos.org/vulkan, is it a mirror of Vulkan-Hpp? |
@M2-TE No, it's the Vulkan-Headers build. That is: that directory doesn't exist, yet, at that point in time. Would you like to change your PR accordingly? |
@asuessenbach That is my bad, makes sense in retrospect.
Yea, I'll simply have CMake emit a warning if the include directory appears be missing. |
Using following priority to determine where to get the C headers:
Vulkan-Headers
subdirectory, if submodule is pulledVulkan::Headers
target, if present (e.g. viaFindVulkan
oradd_subdirectory
)Vulkan::Headers
target, requiringFindVulkan