CI: Attempt to fix build failure on windows #2084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window CI sometimes fails due to "permission errors":
Output
I've encountered this sort of error in other projects on windows when trying to write to still opened files. The only place in the generator code where this error can occur is in the
writeToFile
function, specifically after closing theofstream
and trying to write to the newly created file viaclangd-format
:Vulkan-Hpp/XMLHelper.hpp
Lines 560 to 576 in 8ab6cb5
Normally, I would expect
ofs.close()
to flush the stream, but as it never explicitly callsflush()
internally, I've added it manually. Let's see if it actually helps..