-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup GitHub action script #1421
Conversation
CI Vulkan-Loader build queued with queue ID 105049. |
CI Vulkan-Loader build # 2424 running. |
CI Vulkan-Loader build # 2424 passed. |
strategy: | ||
matrix: | ||
cc: [ gcc, clang ] | ||
cxx: [ g++, clang++ ] | ||
compiler: [ {cc: gcc, cxx: g++}, {cc: clang, cxx: clang++} ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifying the compilers this way avoids the need to use exclude
CC: ${{matrix.cc}} | ||
CXX: ${{matrix.cxx}} | ||
|
||
- name: Build the loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed names when I felt they were redundant.
- run: ctest --output-on-failure --test-dir build/ | ||
- run: cmake --install build --prefix build/install | ||
|
||
mac: | ||
runs-on: macos-12 | ||
|
||
runs-on: macos-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos-11 is fixed with CMake 3.28.1
- name: Setup ccache | ||
uses: hendrikmuhs/[email protected] | ||
with: | ||
key: mingw-ccache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed ccache usage since the key was getting duplicated and therefor getting poor utilization. The loader doesn't really need it anyway.
cmake -S. -B build ` | ||
-D BUILD_TESTS=ON ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broke up windows commands via ` which is what powershell accepts
cc: [ gcc, clang ] | ||
cxx: [ g++, clang++ ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compilers weren't getting used at all.
CI Vulkan-Loader build queued with queue ID 105063. |
CI Vulkan-Loader build # 2425 running. |
CI Vulkan-Loader build # 2425 passed. |
CI Vulkan-Loader build queued with queue ID 105078. |
CI Vulkan-Loader build # 2426 running. |
CI Vulkan-Loader build # 2426 passed. |
No description provided.