Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GitHub action script #1421

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Cleanup GitHub action script #1421

merged 1 commit into from
Dec 27, 2023

Conversation

juan-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 105049.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2424 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2424 passed.

strategy:
matrix:
cc: [ gcc, clang ]
cxx: [ g++, clang++ ]
compiler: [ {cc: gcc, cxx: g++}, {cc: clang, cxx: clang++} ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying the compilers this way avoids the need to use exclude

CC: ${{matrix.cc}}
CXX: ${{matrix.cxx}}

- name: Build the loader
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed names when I felt they were redundant.

- run: ctest --output-on-failure --test-dir build/
- run: cmake --install build --prefix build/install

mac:
runs-on: macos-12

runs-on: macos-11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos-11 is fixed with CMake 3.28.1

- name: Setup ccache
uses: hendrikmuhs/[email protected]
with:
key: mingw-ccache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ccache usage since the key was getting duplicated and therefor getting poor utilization. The loader doesn't really need it anyway.

Comment on lines +202 to +205
cmake -S. -B build `
-D BUILD_TESTS=ON `
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broke up windows commands via ` which is what powershell accepts

Comment on lines -126 to -127
cc: [ gcc, clang ]
cxx: [ g++, clang++ ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilers weren't getting used at all.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 105063.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2425 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2425 passed.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 105078.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2426 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2426 passed.

@charles-lunarg charles-lunarg merged commit 4eebcf0 into KhronosGroup:main Dec 27, 2023
42 checks passed
@juan-lunarg juan-lunarg deleted the juan/ci branch December 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants