Add integration testing #1423
Add integration testing #1423
Conversation
Test find_package(VulkanLoader CONFIG) Minimal vulkan.pc testing is also added.
|
CI Vulkan-Loader build queued with queue ID 107231. |
|
CI Vulkan-Loader build # 2431 running. |
|
CI Vulkan-Loader build # 2431 passed. |
There was a problem hiding this comment.
@ncesario-lunarg the utility libraries and vulkan headers also have similar integration testing FWIW.
| @@ -70,11 +70,6 @@ jobs: | |||
| - run: cmake --build build | |||
| - run: ctest --output-on-failure --test-dir build/ | |||
There was a problem hiding this comment.
FYI @ncesario-lunarg who is looking to do similar work in glslang.
ctest now handles the find_package integration testing. Making it require little to no CI effort.
| # NOTE: This check is NOT sufficient to ensure vulkan.pc is actually valid | ||
| - name: Check vulkan.pc exists and validate it | ||
| run: | | ||
| cat /tmp/lib/pkgconfig/vulkan.pc | ||
| pkg-config --validate /tmp/lib/pkgconfig/vulkan.pc |
There was a problem hiding this comment.
The logic is now tested by ctest
| # Test installation | ||
| set(test_install_dir "${CMAKE_CURRENT_BINARY_DIR}/install") | ||
| add_test(NAME integration.install | ||
| COMMAND ${CMAKE_COMMAND} --install ${PROJECT_BINARY_DIR} --prefix ${test_install_dir} --config $<CONFIG> | ||
| ) |
There was a problem hiding this comment.
NOTE: You can go 1 step further and test the BOM (build of materials).
See https://cmake.org/cmake/help/latest/prop_test/PASS_REGULAR_EXPRESSION.html
The CMake book covers this fairly well.
There was a problem hiding this comment.
Also I have an example in VVL:
find_program(GNU_NM NAMES nm)
if (GNU_NM)
# Ensure ANativeActivity_onCreate is being exported
add_test(NAME ANativeActivity_onCreate COMMAND ${GNU_NM} --dynamic $<TARGET_FILE:vk_layer_validation_tests>)
set_tests_properties(ANativeActivity_onCreate
PROPERTIES PASS_REGULAR_EXPRESSION "T ANativeActivity_onCreate"
)
# Ensure compatibility with older Android loaders
add_test(NAME vkEnumerateDeviceExtensionProperties COMMAND ${GNU_NM} --dynamic $<TARGET_FILE:vvl>)
set_tests_properties(vkEnumerateDeviceExtensionProperties
PROPERTIES PASS_REGULAR_EXPRESSION "T vkEnumerateDeviceExtensionProperties"
)
# Ensure compatibility with older Android loaders
add_test(NAME vkEnumerateDeviceLayerProperties COMMAND ${GNU_NM} --dynamic $<TARGET_FILE:vvl>)
set_tests_properties(vkEnumerateDeviceLayerProperties
PROPERTIES PASS_REGULAR_EXPRESSION "T vkEnumerateDeviceLayerProperties"
)
endif()
|
|
||
| # find_package testing currently doesn't work well under cross-compilation scenarios. | ||
| if (CMAKE_CROSSCOMPILING OR | ||
| NOT CMAKE_SIZEOF_VOID_P EQUAL 8) |
There was a problem hiding this comment.
This 1 line was added to make 32 bit builds work without issue. I'm not a fan and it could potentially be handled more elegantly.
There was a problem hiding this comment.
NOTE: The testing here is SUPER minimal.
glslang would need more of course.
Test find_package(VulkanLoader CONFIG)
Minimal vulkan.pc testing is also added.