Only require C compiler #1424
Merged
Only require C compiler #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the loader only requires the C compiler. But by default the C and CXX compilers are enabled. Only enable the C compiler. Move corresponding C++ code into tests directory.
|
CI Vulkan-Loader build queued with queue ID 107767. |
|
CI Vulkan-Loader build # 2433 running. |
|
CI Vulkan-Loader build # 2433 passed. |
juan-lunarg
commented
Dec 28, 2023
Comment on lines
-23
to
-25
| set(THREADS_PREFER_PTHREAD_FLAG ON) | ||
| find_package(Threads REQUIRED) | ||
|
|
There was a problem hiding this comment.
On WIN32 this just ends up wasting time.
| # using GCC or Clang with the regular front end | ||
| if (ENABLE_WERROR) | ||
| target_compile_options(loader_common_options INTERFACE -Werror) | ||
| endif() | ||
| target_compile_options(loader_common_options INTERFACE -Wall -Wextra) | ||
| endif() | ||
|
|
||
| if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang") | ||
| if(CMAKE_C_COMPILER_ID MATCHES "GNU|Clang") |
There was a problem hiding this comment.
Regex handles this all nicely
Comment on lines
+239
to
+241
| if (BUILD_TESTS) | ||
| enable_testing() | ||
| add_subdirectory(tests) |
There was a problem hiding this comment.
Much cleaner/simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the loader only requires the C compiler.
But by default the C and CXX compilers are enabled.
Only enable the C compiler. Move corresponding C++ code into tests directory.