build: API parameterization changes #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 110983. |
|
CI Vulkan-Loader build # 2440 running. |
|
CI Vulkan-Loader build # 2440 passed. |
spencer-lunarg
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
the scripts/ logic is on par how it has been intergrated into the other repos
the rest I have no in-depth knowledge of the loader so will let @charles-lunarg finish the review
|
Thanks, @spencer-lunarg, sure, I hope @charles-lunarg and @juan-lunarg will comment on the respective parts of this change. |
aqnuep
force-pushed
the
api-parameterization
branch
from
0a28574 to
84e5336
Compare
|
CI Vulkan-Loader build queued with queue ID 111557. |
|
CI Vulkan-Loader build # 2441 running. |
|
CI Vulkan-Loader build # 2441 passed. |
charles-lunarg
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API variant parameterization changes to the loader analogously to other Vulkan ecosystem components.