Fix MacOS installation of vkcube #943
Conversation
|
CI Vulkan-Tools build queued with queue ID 104036. |
1 similar comment
|
CI Vulkan-Tools build queued with queue ID 104036. |
|
FYI @richard-lunarg please check this fixes the SDK issue you were having. I tested it locally and it fixes the issue for vkcube |
|
CI Vulkan-Tools build # 1335 running. |
Now the loader is installed in the app so it is self-contained. Just requires fixing up the RPATH. closes #921
|
CI Vulkan-Tools build queued with queue ID 104044. |
|
CI Vulkan-Tools build # 1336 running. |
|
CI Vulkan-Tools build # 1336 passed. |
| install( | ||
| TARGETS vkcubepp | ||
| # Install runtime dependencies like the Vulkan::Loader so the app is self-contained | ||
| RUNTIME_DEPENDENCIES DESTINATION "cube/vkcubepp.app/Contents/Frameworks/" | ||
| BUNDLE DESTINATION "cube" | ||
| ) |
There was a problem hiding this comment.
Note until KhronosGroup/Vulkan-Hpp/pull/1755 is merged this will fail for vkcubepp since it uses the hpp dynamic loader.
Only libvulkan.1.dylib and libvulkan.1.3.274.dylib are automatically being detected as a runtime dependency by cmake. And currently hpp only checks for libvulkan.dylib
While Volk checks for libvulkan.dylib and libvulkan.1.dylib
Which is why vkcube installation will now work but vkcubepp doesn't. When I manually added detection for libvulkan.1.dylib vkcubepp also worked
|
I can confirm this fixes the SDK build issue. Thanks! |
Now the loader is installed in the app so it is self-contained.
Just requires fixing up the RPATH.
closes #921