Skip to content

Revise WEBGL_shader_pixel_local_storage extension.#3765

Merged
kenrussell merged 2 commits intoKhronosGroup:mainfrom
kenrussell:pls-usage
Feb 23, 2026
Merged

Revise WEBGL_shader_pixel_local_storage extension.#3765
kenrussell merged 2 commits intoKhronosGroup:mainfrom
kenrussell:pls-usage

Conversation

@kenrussell
Copy link
Member

Add noncoherent usage flag, and renumber enums, to track the current ANGLE extension.

Tested against the revised extension implementation in Chromium.

Associated with https://issues.angleproject.org/issues/40096838 .

Add noncoherent usage flag, and renumber enums, to track the current
ANGLE extension.

Tested against the revised extension implementation in Chromium.

Associated with https://issues.angleproject.org/issues/40096838 .
@lexaknyazev
Copy link
Member

Please make the following changes.

  • In the XML:
    • update the getFramebufferPixelLocalStorageParameterWEBGL description to include the new PIXEL_LOCAL_USAGE_WEBGL parameter name.
  • In the test:
    • update all calls to framebufferTexturePixelLocalStorageWEBGL to pass zero for usage;
    • update checkInitialValues to check that initial usage value is zero.

Specify and test PLS framebuffer query of PIXEL_LOCAL_USAGE_WEGBL, and
add usage parameter to framebufferTexturePixelLocalStorageWEBGL calls
in the test.
@kenrussell
Copy link
Member Author

  • In the XML:

    • update the getFramebufferPixelLocalStorageParameterWEBGL description to include the new PIXEL_LOCAL_USAGE_WEBGL parameter name.

Done.

  • In the test:

    • update all calls to framebufferTexturePixelLocalStorageWEBGL to pass zero for usage;

Done.

  • update checkInitialValues to check that initial usage value is zero.

Done, thanks. This caught a bug in Chromium's extension implementation.

@kenrussell kenrussell merged commit 8fc2a0d into KhronosGroup:main Feb 23, 2026
2 checks passed
@kenrussell kenrussell deleted the pls-usage branch February 23, 2026 22:01
kenrussell added a commit to kenrussell/WebGL that referenced this pull request Mar 11, 2026
framebufferTexturePixelLocalStorageWEBGL now takes 5 arguments.

Follow-on to KhronosGroup#3765.
kenrussell added a commit that referenced this pull request Mar 11, 2026
framebufferTexturePixelLocalStorageWEBGL now takes 5 arguments.

Follow-on to #3765.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants