Repository navigation
Tests: Improve resource sorting assertions - #155
Merged
Merged
Conversation
Updates the requirements on convertkit/convertkit-wordpress-libraries to permit the latest version. --- updated-dependencies: - dependency-name: convertkit/convertkit-wordpress-libraries dependency-version: 2.8.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…into dependabot/composer/convertkit/convertkit-wordpress-libraries-2.8.1
n7studios
marked this pull request as ready for review
November 2, 2026 10:40
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
November 2, 2026 10:40
…rtkit-wordpress-libraries-2.8.1 Update convertkit/convertkit-wordpress-libraries requirement from 2.8.0 to 2.8.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resource tests asserted the first and last resource names, which break whenever a sequence, tag, form or custom field is added to the test Kit account. Replaces these with assertions that don't depend on which resources exist, ported from the main Kit Plugin (#1264):
assertResourcesSorted(): checks resources are sorted by the resource class'order_byandorderproperties, using the samestrcmpcomparison as the resource class.assertResourcesInOriginalOrder(): checks resources are returned unsorted whenorder_byis invalid.Testing
Checklist