Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 API: Tests: Run wordpress endpoint tests #58

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Apr 26, 2024

Summary

Runs tests using the wordpress endpoint, that were previously marked as incomplete, resolving:

  • Reinstating the missing recommendations_script method, that previously existed.
  • Adding an api_key parameter to get_form_html for fetching legacy forms, as the v4 API does not use API Keys or list legacy forms. This method may be used by the main ConvertKit Plugin to support existing legacy forms that were previously defined in the Plugin or a shortcode/block.
  • Removes testBackwardCompat* tests for methods that were marked deprecated in v1 of our WordPress Libraries, as these functions are removed in this v2 WordPress Library.

Testing

Tests pass.

Checklist

@n7studios n7studios added the enhancement New feature or request label Apr 26, 2024
@n7studios n7studios added this to the 2.0 milestone Apr 26, 2024
@n7studios n7studios self-assigned this Apr 26, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team April 26, 2024 17:50
@n7studios n7studios marked this pull request as ready for review April 26, 2024 17:50
@n7studios n7studios merged commit 81cb3fa into v4-api Apr 29, 2024
5 checks passed
@n7studios n7studios deleted the v4-api-tests-wordpress-endpoint branch June 26, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants