v4 API: Resources: Include Legacy Forms and Landing Pages #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the ConvertKit Plugin to directly fetch HTML using a legacy form’s `embed_url` property, which includes the API Key.
…nd landing pages Uses the new v4 methods `get_legacy_forms` and `get_legacy_landing_pages` when refreshing/caching forms and landing pages through a resource class, to ensure that all available forms / landing pages are returned.
n7studios
requested review from
a team,
noelherrick and
jenessawhite
and removed request for
a team
noelherrick
approved these changes
May 28, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the resource class' method when refreshing Forms and Landing Pages to include legacy items.
Makes
get_htmla public method, so that the main ConvertKit Plugin can fetch a legacy form using theembed_urlproperty, as this includes theapi_keyrequired to authenticate and fetch the HTML to output. As the Plugin is using OAuth, it may not reliably always have a a historical API Key in its settings.Testing
testRefreshForms: Updated test to confirm legacy form is included in the resultset, with the required data.testRefreshLandingPages: Updated test to confirm legacy landing page is included in the resultset, with the required data.Checklist