Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace convertkit.com with kit.com #76

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Replace convertkit.com with kit.com #76

merged 13 commits into from
Sep 30, 2024

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Jul 22, 2024

Summary

Replaces convertkit.com with kit.com

Testing

Existing tests pass

Checklist

@n7studios n7studios added the enhancement New feature or request label Jul 22, 2024
@n7studios n7studios self-assigned this Jul 22, 2024
@n7studios n7studios marked this pull request as ready for review September 18, 2024 06:07
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team September 18, 2024 06:07
@n7studios
Copy link
Contributor Author

@noelherrick There's still 4 lines in the tests that need to reference convertkit.com:

Fetching Legacy Landing Pages via the API:

https://api.convertkit.com/v4/landing_pages?type=hosted
{
    "legacy_landing_pages": [
        {
            "id": 470103,
            "name": "Legacy Landing Page",
            "created_at": null,
            "type": "hosted",
            "url": "https://app.convertkit.com/landing_pages/470103",
            "embed_js": "https://api.convertkit.com/api/v3/forms/470103.js?api_key={apikey}",
            "embed_url": "https://api.convertkit.com/api/v3/forms/470103.html?api_key={apikey}",
            "title": "",
            "description": "",
            "sign_up_button_text": "Register",
            "success_message": null,
            "archived": false
        }
    ],
    ...
}

Fetching HTML for a legacy form e.g https://api.kit.com/forms/470099/embed?v=2&k={apikey}

  • The form HTML in the returned legacy form is <form id="ck_subscribe_form" class="ck_subscribe_form" action="https://api.convertkit.com/landing_pages/470099/subscribe" data-remote="true">

Fetching HTML for a landing page e.g. https://cheerful-architect-3237.ck.page/99f1db6843

  • The form HTML in the returned hosted landing page is <form method="POST" action="https://app.convertkit.com/forms/2765196/subscriptions"

Fetching HTML for a landing page e.g. https://cheerful-architect-3237.ck.page/cc5eb21744

  • The form HTML in the returned hosted landing page is <form method="POST" action="<form method="POST" action="https://app.convertkit.com/forms/2849151/subscriptions""

Would the <form> URLs change once the switch is fully made to kit.com from convertkit.com?

Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n7studios That's correct - all URLs will change, including *.ck.page URLs. Those will now be hosted on *.kit.com

@n7studios
Copy link
Contributor Author

@n7studios That's correct - all URLs will change, including *.ck.page URLs. Those will now be hosted on *.kit.com

Okay, great - I'll submit a PR with amended tests once the URLs change to *.kit.com. Thanks!

@n7studios n7studios merged commit dfe074e into main Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants