-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Run tests using ubuntu-latest
#88
Conversation
@n7studios Tim, I was noticing we use a rather expansive permission grant for tests - should we match the recommended permission for WordPress plugins, such as setting it to read-only for the group and others? Thoughts? |
From memory, they were expansive for allowing Plugins to write to logs, and mainly to stop Codeception throwing some errors when trying to write to the tests/output folder when a GitHub action test fails. Let me review this and if less expansive permissions work, I'll submit then in a PR. |
…api-key Add `client_id` to `accounts/oauth_access_token`
Summary
Runs tests against ubuntu-latest, as ubuntu-20.04 will be deprecated: actions/runner-images#11101.
Moves creation of the nginx configuration within the GitHub action, and uses nginx's default
/var/www/html
folder for serving the WordPress site.Testing
Existing tests pass.
Checklist