Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Run tests using ubuntu-latest #88

Merged
merged 9 commits into from
Mar 12, 2025

Conversation

n7studios
Copy link
Contributor

Summary

Runs tests against ubuntu-latest, as ubuntu-20.04 will be deprecated: actions/runner-images#11101.

Moves creation of the nginx configuration within the GitHub action, and uses nginx's default /var/www/html folder for serving the WordPress site.

Testing

Existing tests pass.

Checklist

@n7studios n7studios added the enhancement New feature or request label Mar 2, 2025
@n7studios n7studios self-assigned this Mar 2, 2025
@n7studios n7studios changed the base branch from main to updated-coding-standards March 10, 2025 06:04
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 10, 2025 06:04
@n7studios n7studios marked this pull request as ready for review March 10, 2025 06:04
@noelherrick
Copy link

@n7studios Tim, I was noticing we use a rather expansive permission grant for tests - should we match the recommended permission for WordPress plugins, such as setting it to read-only for the group and others? Thoughts?

@n7studios
Copy link
Contributor Author

@n7studios Tim, I was noticing we use a rather expansive permission grant for tests - should we match the recommended permission for WordPress plugins, such as setting it to read-only for the group and others? Thoughts?

From memory, they were expansive for allowing Plugins to write to logs, and mainly to stop Codeception throwing some errors when trying to write to the tests/output folder when a GitHub action test fails. Let me review this and if less expansive permissions work, I'll submit then in a PR.

@n7studios n7studios merged commit 1a8c827 into updated-coding-standards Mar 12, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants