Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Update Tests to match API behaviour #89

Merged
merged 16 commits into from
Mar 12, 2025
Merged

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Mar 10, 2025

Summary

Updates existing tests:

  • Tags: creating a tag that exists returns the tag (previously, the API would return an error)
  • Before / after params: set sensible before/after dates, now the test Kit account has had the majority of its test subscribers removed
  • Apply the timezone offset (-04:00 or -05:00) depending on whether daylight savings time is active

Testing

Existing tests pass.

Checklist

@n7studios n7studios added the enhancement New feature or request label Mar 10, 2025
@n7studios n7studios self-assigned this Mar 10, 2025
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 10, 2025 05:09
@n7studios n7studios marked this pull request as ready for review March 10, 2025 05:09
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n7studios Have you communicated to the Platform team that there's an error in the API already?

@n7studios
Copy link
Contributor Author

@n7studios Have you communicated to the Platform team that there's an error in the API already?

Yes - waiting to hear back. Will hold off to confirm whether the 500 error on bulk/tags with blank tag names is a bug or expected behaviour.

@n7studios
Copy link
Contributor Author

500 error from the API resolved in this PR; reverted test accordingly.

…api-key

Add `client_id` to `accounts/oauth_access_token`
Tests: Run tests using `ubuntu-latest`
Use `WordPress` Coding Standards ruleset
@n7studios n7studios merged commit ef5ffa9 into main Mar 12, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants