Skip to content

feat(viewer mode): add modes to control the available actions in the viewer - #19

Merged
Justineantoine merged 4 commits into
mainfrom
viewer-mode
Sep 8, 2026
Merged

Justineantoine merged 4 commits into
mainfrom
viewer-mode

Conversation

@Justineantoine

Copy link
Copy Markdown
Collaborator

Changes:

  • Add RCAViewerMode to control the RCA handled events
  • Add EEGAnnotatorMode:
    • Annotate : activated only when new annotation or existing one belonging to the user
    • Review: activated only when annotation "in review" and not belonging to the user
    • Done: activated when the EEG fileset is done
    • Read-only: activated when none of the above matches
    • Undefined : default status when no EEG fileset is selected (avoid UI shifting when loading data to the viewer)
  • Add Action button depending on the mode:
    • Annotate : save, submit, delete
    • Review: approve, reject
    • Done, Read only: lock with read only text
    • Undefined : empty placeholder
image

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename "EEG fileset" text into "EEG"
  • Rename "Annotations file" text into "Annotations"
  • It's too bad that the "Actions" are not more part of "Annotations". Can you great a unique Annotations group around the Select and the list of buttons ?
  • a "Submit for review" should probably "save" the annotation first.

@Justineantoine

Justineantoine commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author
  • Rename "EEG fileset" text into "EEG"

👍

  • Rename "Annotations file" text into "Annotations"

👍

  • It's too bad that the "Actions" are not more part of "Annotations". Can you great a unique Annotations group around the Select and the list of buttons ?
image image Is it better ? (maybe removing the dividers between the actions)
  • a "Submit for review" should probably "save" the annotation first.

done in the latest PR :)

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from rework-viewer to main September 8, 2026 08:32
@Justineantoine
Justineantoine merged commit 3f1edf3 into main Sep 8, 2026
4 checks passed
@Justineantoine
Justineantoine deleted the viewer-mode branch September 8, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants