Skip to content

Conversation

@timcogan
Copy link
Contributor

With minor changes to test_anon.py, all tests are passing with pydicom>=3.

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Some linting tests are failing though.
Did you check it still works with pydicom<3 ?

@timcogan
Copy link
Contributor Author

No problem! The code should still work with pydicom<3.

@pchoisel
Copy link
Collaborator

Thank you for your contribution, the modifications look good and the test pass.
However, I'm not a fan of the Makefile, could you remove it ?
After that, I'll merge the modications

@pchoisel
Copy link
Collaborator

Thank you !

@pchoisel pchoisel merged commit e8a5457 into KitwareMedical:master Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants