Skip to content

await driver methods #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssxv wants to merge 3 commits into
base: master
Choose a base branch
from
Open

await driver methods #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdfb25d
fix: await driver.getPrinter in isPrinterConnected method
ssxv Feb 8, 2026
f530fd1
fix: await driver.getPrinters in getPrinterName and update printer re…
ssxv Feb 14, 2026
db07312
async getPrinterName in interface
ssxv Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/interfaces/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class Interface {
getPrinterName () {
async getPrinterName () {
throw new Error("'getPrinterName' function not implemented.");
}

Expand Down
11 changes: 7 additions & 4 deletions lib/interfaces/printer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ class Printer extends Interface {
}
}

getPrinterName () {
async getPrinterName () {
let { name } = this;
if (!name || name === 'auto') {
const pl = this.driver.getPrinters().filter((p) => p.attributes.indexOf('RAW-ONLY') > -1);
const printers = await this.driver.getPrinters();
const pl = printers.filter((p) => p.attributes.indexOf('RAW-ONLY') > -1);
if (pl.length > 0) {
name = pl[0].name;
}
Expand All @@ -26,18 +27,20 @@ class Printer extends Interface {
}

async isPrinterConnected () {
const foundPrinter = this.driver.getPrinter(this.getPrinterName());
const printerName = await this.getPrinterName();
const foundPrinter = await this.driver.getPrinter(printerName);
if (foundPrinter && foundPrinter.status.indexOf('NOT-AVAILABLE') === -1) {
return true;
}
throw false;
}

async execute (buffer, options = {}) {
const printerName = await this.getPrinterName();
return new Promise((resolve, reject) => {
this.driver.printDirect({
data: buffer,
printer: this.getPrinterName(),
printer: printerName,
type: 'RAW',
docname: options.docname !== undefined ? options.docname : false,
success (jobID) {
Expand Down